Differential D27535

Add XdgOutputV1 version 2
ClosedPublic
Actions

Authored by davidedmundson on Feb 21 2020, 1:04 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:8b355825a3b8: Add XdgOutputV1 version 2
Summary

Will be useful for making plasma widgets not move about
on multi monitor. QtWayland already supports it

Test Plan

Unit test

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 21 2020, 1:04 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 21 2020, 1:04 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 21 2020, 1:04 AM
davidedmundson updated this revision to Diff 76077.

update

apol added a subscriber: apol.Feb 21 2020, 1:34 AM

+1 LGTM

src/server/xdgoutput_interface.cpp
305

noob question: what would happen if you didn't have this check?

zzag accepted this revision.Feb 21 2020, 8:11 AM
This revision is now accepted and ready to land.Feb 21 2020, 8:11 AM
davidedmundson added inline comments.Feb 21 2020, 1:43 PM
src/server/xdgoutput_interface.cpp
305

If a client that only knew version1 connected and we sent this event, the client would raise a protocol error and quit.

Closed by commit R127:8b355825a3b8: Add XdgOutputV1 version 2 (authored by davidedmundson). · Explain WhyMar 24 2020, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78345

View Options

autotests/client/test_xdg_output.cpp

Loading...
View Options

src/client/registry.cpp

Loading...
View Options

src/client/xdgoutput.h

Loading...
View Options

src/client/xdgoutput.cpp

Loading...
View Options

src/server/xdgoutput_interface.h

Loading...
View Options

src/server/xdgoutput_interface.cpp

Loading...