| nicolasfella | |
| vkrause |
| Frameworks |
KNotifications assigns the ID 0 to the default action on a notification (the one when the notification itself is selected). Additional actions (buttons on the notification) are counted starting with 1.
In the Android backend however, the default action has ID 0 and the additional actions are counted starting with 0 as well. This has been fixed to work as described above.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 23092 | |
| Build 23110: arc lint + arc unit |
Thanks for the patch, makes sense.
Please make the commit message a bit more elaborate
I added a summary here.
I also wanted to fix it directly in the commit. Besides, I didn't set the committer e-mail address correctly, so I'd like to fix that as well.
How can I edit the commit with arc? Or can I just git commit --amend and push?
Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik.
To apply the changes made in the web interface to your local commit you use arc amend I think.
To upload new changes you do arc diff --update D27528
Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik.
It does not. It uses whatever authorship info is in the uploaded patch, which may be empty if the patch was uploaded via the web interface. Always check that if you are landing other people's patches!
Let's get this in. Can you please give me your full name and email address so I can merge this?
Adapt action numbering in Android to work like in KNotifications
Summary:
KNotifications assigns the ID 0 to the default action on a notification (the
one when the notification itself is selected). Additional actions (buttons on
the notification) are counted starting with 1.
In the Android backend however, the default action has ID 0 and the additional
actions are counted starting with 0 as well. This has been fixed to work as
described above.
Reviewers: Frameworks, nicolasfella, vkrause
Subscribers: kde-frameworks-devel
Tags: Frameworks
Differential Revision: https://phabricator.kde.org/D27528
I have tried all the suggested commands, none of them worked. I opened a new merge request where everything is correct:
https://phabricator.kde.org/D27740
Can you delete this merge request or tell me how I can do it?
Sorry for the questions, but I have never worked with this system and coming from Git, I don't find it intuitive.