Adapt action numbering in Android to work like in KNotifications
ClosedPublic

Authored by cacahueto on Feb 20 2020, 6:41 PM.

Details

Reviewers
nicolasfella
vkrause
Group Reviewers
Frameworks
Summary

KNotifications assigns the ID 0 to the default action on a notification (the one when the notification itself is selected). Additional actions (buttons on the notification) are counted starting with 1.

In the Android backend however, the default action has ID 0 and the additional actions are counted starting with 0 as well. This has been fixed to work as described above.

Diff Detail

Repository
R289 KNotifications
Branch
adapt-action-numbering-in-android-as-in-knotifications (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23092
Build 23110: arc lint + arc unit
cacahueto created this revision.Feb 20 2020, 6:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 20 2020, 6:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cacahueto requested review of this revision.Feb 20 2020, 6:41 PM

Thanks for the patch, makes sense.

Please make the commit message a bit more elaborate

cacahueto edited the summary of this revision. (Show Details)Feb 21 2020, 9:46 AM

I added a summary here.

I also wanted to fix it directly in the commit. Besides, I didn't set the committer e-mail address correctly, so I'd like to fix that as well.
How can I edit the commit with arc? Or can I just git commit --amend and push?

Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik.

To apply the changes made in the web interface to your local commit you use arc amend I think.

To upload new changes you do arc diff --update D27528

Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik.

It does not. It uses whatever authorship info is in the uploaded patch, which may be empty if the patch was uploaded via the web interface. Always check that if you are landing other people's patches!

nicolasfella accepted this revision.Feb 27 2020, 6:53 PM

Let's get this in. Can you please give me your full name and email address so I can merge this?

This revision is now accepted and ready to land.Feb 27 2020, 6:53 PM
cacahueto updated this revision to Diff 76684.Feb 29 2020, 1:29 PM

Adapt action numbering in Android to work like in KNotifications

Summary:
KNotifications assigns the ID 0 to the default action on a notification (the
one when the notification itself is selected). Additional actions (buttons on
the notification) are counted starting with 1.

In the Android backend however, the default action has ID 0 and the additional
actions are counted starting with 0 as well. This has been fixed to work as
described above.

Reviewers: Frameworks, nicolasfella, vkrause

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D27528

I have tried all the suggested commands, none of them worked. I opened a new merge request where everything is correct:
https://phabricator.kde.org/D27740

Can you delete this merge request or tell me how I can do it?
Sorry for the questions, but I have never worked with this system and coming from Git, I don't find it intuitive.

nicolasfella closed this revision.Mar 1 2020, 3:47 PM