Remove unnecessary monochrome app icons
AbandonedPublic

Authored by ngraham on Feb 19 2020, 5:15 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary

This is a continuation of the ongoing issue we have in reliably making icons colorful
or monochrome in a predictible manner. Currently there are certain app icons that have
monochrome versions, primarily to make them look better in the system tray. However other
monochrome app icons exist for no clear reason. This patch removes those, while not
touching the monochrome app icons.

BUG: 417879
FIXED-IN: 5.68

Test Plan

khelpcenter icon is now consistently colorful in the task manager, window decoration,
and task switcher

One conseauence is that now "Help" menu items and buttons that use the system-help icon
are now colorful, which is arguably correct because those actions will open the KHelpCenter
app, and we generally use colorful app icons in places where actions will open an app.

Diff Detail

Repository
R266 Breeze Icons
Branch
remove-unnecessary-monochrome-app-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22688
Build 22706: arc lint + arc unit
ngraham created this revision.Feb 19 2020, 5:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 19 2020, 5:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 19 2020, 5:15 PM
ngraham edited the summary of this revision. (Show Details)Feb 19 2020, 5:15 PM

I don't know what hotspot is used for, but the other ones are probably used by 3rd party apps. The virt-manager and system-help icons are definitely used by 3rd party apps in places where monochrome icons should be.

Removing the monochrome system-help icon is what's needed to fix 417879, though. If we can't do that, then we can't fix the bug.

Removing the monochrome system-help icon is what's needed to fix 417879, though. If we can't do that, then we can't fix the bug.

We're back to needing to solve the fundamental technical issue with Breeze Icons. Removing or adding icons isn't going to fix it. We've got to create a way to force apps to use monochrome icons when we want to use them and I don't know how to do that. Alternatively, we could redesign Breeze to work better with the XDG spec, but I don't have the time, creativity or drive to create tons of good replacement icons.

ngraham abandoned this revision.Feb 21 2020, 5:59 AM

What's the phab task you filed about this again? I can't find it.