Depends on D27127
Details
Details
- Reviewers
ervin crossi bport - Group Reviewers
Plasma - Commits
- R119:ca02af6584c6: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- arcpatch-D27480
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22855 Build 22873: arc lint + arc unit
solid-device-automounter/kded/DeviceAutomounter.cpp | ||
---|---|---|
39 ↗ | (On Diff #75923) | m_settings need to go to the next line |
solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
---|---|---|
44 ↗ | (On Diff #75923) | please break the line before ", m_devices" |
solid-device-automounter/kcm/DeviceModel.cpp | ||
34 ↗ | (On Diff #75923) | m_settings on its own line? |
solid-device-automounter/kcm/DeviceModel.h | ||
37 ↗ | (On Diff #75923) | parent should come last and keep the = nullptr |
solid-device-automounter/kded/DeviceAutomounter.cpp | ||
111 ↗ | (On Diff #75923) | This is rather odd. A too eager search and replace? ;-) |
solid-device-automounter/lib/AutomounterSettings.cpp | ||
23 ↗ | (On Diff #75923) | I guess you could have used using AutomounterSettingsBase::AutomounterSettingsBase; in the header instead. |
solid-device-automounter/lib/AutomounterSettings.h | ||
31 ↗ | (On Diff #75923) | No space between the parenthesis |