Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings
ClosedPublic

Authored by meven on Feb 18 2020, 3:12 PM.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D27127
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22635
Build 22653: arc lint + arc unit
meven created this revision.Feb 18 2020, 3:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 3:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Feb 18 2020, 3:12 PM
bport accepted this revision.Feb 20 2020, 8:51 AM
bport added inline comments.
solid-device-automounter/kded/DeviceAutomounter.cpp
39

m_settings need to go to the next line

This revision is now accepted and ready to land.Feb 20 2020, 8:51 AM
ervin requested changes to this revision.Feb 24 2020, 11:05 AM
ervin added inline comments.
solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
44

please break the line before ", m_devices"

solid-device-automounter/kcm/DeviceModel.cpp
34

m_settings on its own line?

solid-device-automounter/kcm/DeviceModel.h
37

parent should come last and keep the = nullptr

solid-device-automounter/kded/DeviceAutomounter.cpp
111

This is rather odd. A too eager search and replace? ;-)

solid-device-automounter/lib/AutomounterSettings.cpp
23

I guess you could have used using AutomounterSettingsBase::AutomounterSettingsBase; in the header instead.

solid-device-automounter/lib/AutomounterSettings.h
31

No space between the parenthesis

This revision now requires changes to proceed.Feb 24 2020, 11:05 AM
meven updated this revision to Diff 76294.Feb 24 2020, 2:05 PM
meven marked 7 inline comments as done.

Rebase, review fix

meven added inline comments.Feb 24 2020, 2:06 PM
solid-device-automounter/kded/DeviceAutomounter.cpp
111

Thanks indeed

solid-device-automounter/lib/AutomounterSettings.cpp
23

Nice suggestion

meven marked 2 inline comments as done.Feb 24 2020, 2:06 PM
ervin accepted this revision.Feb 24 2020, 3:25 PM
This revision is now accepted and ready to land.Feb 24 2020, 3:25 PM
This revision was automatically updated to reflect the committed changes.