Differential D27477

KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT
ClosedPublic
Actions

Authored by meven on Feb 18 2020, 2:12 PM.

Details

Reviewers
crossi
bport
ervin
zzag
Group Reviewers
KWin
Commits
R108:d571457bbe10: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT
Summary

Depends on D27463

Diff Detail

Repository
R108 KWin
Branch
arcpatch-D27477
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22658
Build 22676: arc lint + arc unit
meven created this revision.Feb 18 2020, 2:12 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 18 2020, 2:12 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
meven requested review of this revision.Feb 18 2020, 2:12 PM
meven updated this revision to Diff 75970.Feb 19 2020, 9:16 AM

Bump KWin dependency to KF 5.68

bport added inline comments.Feb 20 2020, 9:04 AM
kcmkwin/kwinoptions/mouse.cpp
158

I don't think we need a t variable there

meven updated this revision to Diff 76041.Feb 20 2020, 10:14 AM
meven marked an inline comment as done.

Clean leftover scratchpad code

ervin requested changes to this revision.Feb 24 2020, 12:18 PM
ervin added inline comments.
kcmkwin/kwinoptions/mouse.cpp
139–140 ↗(On Diff #75916)

Please use the opportunity to remove the space after the *

163–164 ↗(On Diff #75916)

I guess it could be completely removed

211–212 ↗(On Diff #75916)

ditto

This revision now requires changes to proceed.Feb 24 2020, 12:18 PM
meven updated this revision to Diff 76404.Feb 25 2020, 6:18 PM
meven marked 2 inline comments as done.

Remove unneeded destructors, code style

zzag added a subscriber: zzag.Feb 25 2020, 8:17 PM

+1, nice cleanup

ervin accepted this revision.Feb 26 2020, 10:16 AM
This revision is now accepted and ready to land.Feb 26 2020, 10:16 AM
meven added inline comments.Mar 5 2020, 8:34 AM
kcmkwin/kwinoptions/main.cpp
196

That's wrong, those lines should not be removed

meven updated this revision to Diff 77007.Mar 5 2020, 10:39 AM

Avoid removing window options from the kwinactions kcm

ervin requested changes to this revision.Mar 5 2020, 3:51 PM
ervin added inline comments.
kcmkwin/kwinoptions/kwinoptions_settings.kcfg
65 ↗(On Diff #75916)

Camel case (you camel cased the other similar ones)

66 ↗(On Diff #75916)

Ditto

kcmkwin/kwinoptions/main.cpp
210

Sure about that?

234

Sure about that?

(This comment and the previous one are due to you apparently reverting a past mistake but I wonder if you missed a bit of it)

This revision now requires changes to proceed.Mar 5 2020, 3:51 PM
meven updated this revision to Diff 77227.Mar 8 2020, 6:06 PM
meven marked 4 inline comments as done.

KCM/Kwinoptions: Port Focus tab to KConfigXT

meven updated this revision to Diff 77228.Mar 8 2020, 6:07 PM

Remove bad diff

meven updated this revision to Diff 77233.Mar 8 2020, 6:21 PM

Address review

ervin accepted this revision.Mar 16 2020, 8:44 AM
This revision is now accepted and ready to land.Mar 16 2020, 8:44 AM
zzag accepted this revision.Mar 16 2020, 8:51 AM
meven marked 2 inline comments as done.Mar 16 2020, 10:29 AM
Closed by commit R108:d571457bbe10: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT (authored by meven). · Explain WhyMar 19 2020, 11:40 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 75970

View Options

CMakeLists.txt

Loading...
View Options

kcmkwin/kwinoptions/kwinoptions_settings.kcfg

Loading...
View Options

kcmkwin/kwinoptions/mouse.cpp

Loading...