Differential D27471

[plasma-session] Avoid potential race condition starting a service
ClosedPublic
Actions

Authored by davidedmundson on Feb 18 2020, 10:06 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:854b64fc130b: [plasma-session] Avoid hypothetical race condition starting a service
Summary

If for some reason a service is started before StartServiceJob runs, we
will end up blocking forever.

Test Plan

Logged in

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22618
Build 22636: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 10:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 18 2020, 10:06 AM
apol accepted this revision.Feb 18 2020, 12:08 PM
This revision is now accepted and ready to land.Feb 18 2020, 12:08 PM
Closed by commit R120:854b64fc130b: [plasma-session] Avoid hypothetical race condition starting a service (authored by davidedmundson). · Explain WhyFeb 18 2020, 12:40 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Feb 18 2020, 12:45 PM
broulik added inline comments.
startkde/plasma-session/startup.cpp
427

Could probably use an m_service.isEmpty() check since it will still needlessly do a NameHasOwner call

davidedmundson added inline comments.Feb 18 2020, 12:47 PM
startkde/plasma-session/startup.cpp
427

All usages of this class (which is just the 1 case to start ksmserver!) have a name passed.

Without a name it wouldn't ever finish.

Revision Contents
Changeset List

Diff 75902

View Options

startkde/plasma-session/startup.h

Loading...
View Options

startkde/plasma-session/startup.cpp

Loading...