[Applet]Update toolbar's checkbox spacing
ClosedPublic
Actions

Authored by gvgeo on Feb 17 2020, 10:30 AM.

Details

Reviewers

jgrulich
ngraham

Group Reviewers

Plasma
VDG

Maniphest Tasks

T10470: Improve the visuals of tray popups

Commits

R116:88b8ce5e50b7: [Applet]Update toolbar's checkbox spacing

Summary

Move the switchButton's icon smallSpacing left.
Make icon size smallMedium.

BUG: 417710

Test Plan

Before:

After:

Repository

R116 Plasma Network Management Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gvgeo requested review of this revision.Feb 17 2020, 10:30 AM

broulik added inline comments.

applet/contents/ui/SwitchButton.qml
54 ↗	(On Diff #75815)	Can this bug be fixed? Or is that because we use a `CheckBox` without a label and so it is icon width + spacing + no label?

applet/contents/ui/SwitchButton.qml
54 ↗	(On Diff #75815)	I made some tests. I even comment out in checkbox style, label and background but always added spacing. Only workaround that found to work, was to set `spacing: control.text ? smallSpacing : 0`, but didn't felt right way to do it.