Diff Detail
- Branch
- /trunk/www/sites/www
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22559 Build 22577: arc lint + arc unit
The indentation for the file is not consistent, please use 2 spaces and don't create an empty new line just after opening a new tag or just before closing a tag. Also please use the xhtml syntax for self-closing tag (<br /> instead of <br>).
Make sure all the content is in a <main> tag and each section in a separate <section> tag.
Bad
<div> <div> <span>Text</span> <br> </div> </div>
Good
<div> <div> <span>Text</span> <br /> </div> </div>
develop.php | ||
---|---|---|
8 | Indentation is broken and a coma is missing at the end. | |
56 | Please remove this button and the css code for it. If we want to add such a button it should be for the complete website. | |
356 | Don't use <br> and instead give the items an block display. |
Can you explain the process of choosing which frameworks to highlight?
Why are we listing flatpack as the first deployment option and distros last? Is the order random or do you want to show a preference here?
develop.php | ||
---|---|---|
158 | Did you count all frameworks? Also this number is not static and subject to changes | |
203 | Caps feel weird here. | |
329 | I would move this in the top row as it documentation of developing for one of our products and the inqlude one down next to Qt. |
develop.php | ||
---|---|---|
351 | Documentation is unspecific. Right above you list various different documentations, how should I know what this link does? |
develop.php | ||
---|---|---|
351 | The more I look at this list of links, the more I think they should go away completely. All of then are already available in the footer anyway |
develop.php | ||
---|---|---|
158 | I was following what was written here https://kde.org/products/frameworks/ |
For frameworks, 3 of them were suggested by Carson Black. And the other were mentioned in a couple of places outside api.kde.org . I guess you can consider that the choosing was random
for packaging, It was random. Pls suggest the preference order so that I can make the necessary changes
I don't have any preffered order I was just curious since it didn't appear to be for example alphabetically
Made the necessary changes to the identation and added xhtml syntax for self-closing tabs
@ognarb I made the changes in the identation style as suggested. Pls review it. Sorry for this late reply, I was busy with exams
develop.php | ||
---|---|---|
107 | I would probably drop the question at the beginning of this paragraph, and rewrite this sentence to sound more confident instead of using "can use." | |
108 | I would drop "the best thing" and "i.e." as they don't make the sentence sound very professional. | |
181–220 | This section has some style problems:
| |
228 | I would probably drop "KDE" from here | |
229 | Like above, drop the question and rewrite. You probably don't need this sentence in the first place anyways. | |
231–263 | Like above, don't duplicate the name of the tools when describing them | |
264–266 | Not sure I would have the HIG be just a "pro tip" | |
268–306 | Again, inconsistent period usage and duplication of format name | |
294–296 | Duplication of tool name | |
300 | Distro packaging probably shouldn't link to the appimage github. | |
334–335 | I would drop "KDE isn't the only community developing with Qt," "not just those by the KDE community," and drop duplication of tool name. |
Made the changes as suggested by cblack. Not sure if this is what was expected. Pls review
develop.php | ||
---|---|---|
194 | Drop Providing, to→for. |
Probably no longer relevant if we go ahead with the plan of a developer portal (https://invent.kde.org/carlschwan/developer-kde-org).