Refresh developer page
Needs RevisionPublic

Authored by crusader on Feb 17 2020, 3:44 AM.

Details

Reviewers
ognarb
cblack
Test Plan

Diff Detail

Branch
/trunk/www/sites/www
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22838
Build 22856: arc lint + arc unit
crusader requested review of this revision.Feb 17 2020, 3:44 AM
crusader created this revision.
cblack retitled this revision from Sok20_project to Refresh developer page.Feb 17 2020, 3:48 AM
cblack added reviewers: ognarb, cblack.
crusader edited the test plan for this revision. (Show Details)Feb 17 2020, 3:52 AM

The indentation for the file is not consistent, please use 2 spaces and don't create an empty new line just after opening a new tag or just before closing a tag. Also please use the xhtml syntax for self-closing tag (<br /> instead of <br>).

Make sure all the content is in a <main> tag and each section in a separate <section> tag.

Bad

<div>
    <div>

      <span>Text</span>
     <br>
   </div>

</div>

Good

<div>
  <div>
    <span>Text</span>
    <br />
  </div>
</div>
develop.php
8

Indentation is broken and a coma is missing at the end.

71

Please remove this button and the css code for it. If we want to add such a button it should be for the complete website.

281

Don't use <br> and instead give the items an block display.

ognarb requested changes to this revision.Feb 17 2020, 8:11 AM
This revision now requires changes to proceed.Feb 17 2020, 8:11 AM

Can you explain the process of choosing which frameworks to highlight?

Why are we listing flatpack as the first deployment option and distros last? Is the order random or do you want to show a preference here?

develop.php
119

Caps feel weird here.

136

Did you count all frameworks? Also this number is not static and subject to changes

254–255

I would move this in the top row as it documentation of developing for one of our products and the inqlude one down next to Qt.

davidre added inline comments.Feb 17 2020, 8:50 AM
develop.php
276

Documentation is unspecific. Right above you list various different documentations, how should I know what this link does?

ognarb added inline comments.Feb 17 2020, 10:01 AM
develop.php
276

The more I look at this list of links, the more I think they should go away completely. All of then are already available in the footer anyway

The documentation was a part of the original page which is why I didn't remove it.

The documentation was a part of the original page which is why I didn't remove it.

I mean the "Here are some useful links" section

@ognarb I will remove them

crusader updated this revision to Diff 75849.Feb 17 2020, 5:56 PM

Removed excess links at the end of page

crusader updated this revision to Diff 75853.Feb 17 2020, 6:17 PM
crusader marked an inline comment as done.

Made some minor changes

crusader marked 5 inline comments as done.Feb 17 2020, 6:18 PM
crusader added inline comments.
develop.php
136

I was following what was written here https://kde.org/products/frameworks/

Can you explain the process of choosing which frameworks to highlight?

Why are we listing flatpack as the first deployment option and distros last? Is the order random or do you want to show a preference here?

For frameworks, 3 of them were suggested by Carson Black. And the other were mentioned in a couple of places outside api.kde.org . I guess you can consider that the choosing was random

for packaging, It was random. Pls suggest the preference order so that I can make the necessary changes

crusader edited the test plan for this revision. (Show Details)Feb 18 2020, 4:25 AM

Can you explain the process of choosing which frameworks to highlight?

Why are we listing flatpack as the first deployment option and distros last? Is the order random or do you want to show a preference here?

For frameworks, 3 of them were suggested by Carson Black. And the other were mentioned in a couple of places outside api.kde.org . I guess you can consider that the choosing was random

for packaging, It was random. Pls suggest the preference order so that I can make the necessary changes

I don't have any preffered order I was just curious since it didn't appear to be for example alphabetically

crusader updated this revision to Diff 76143.Feb 22 2020, 7:06 AM

Made the necessary changes to the identation and added xhtml syntax for self-closing tabs

crusader marked an inline comment as done.Feb 22 2020, 7:09 AM

@ognarb I made the changes in the identation style as suggested. Pls review it. Sorry for this late reply, I was busy with exams

cblack added inline comments.Feb 22 2020, 4:01 PM
develop.php
72

I would probably drop the question at the beginning of this paragraph, and rewrite this sentence to sound more confident instead of using "can use."

73

I would drop "the best thing" and "i.e." as they don't make the sentence sound very professional.

97–136

This section has some style problems:

  • Periods are used inconsistently
  • I would probably not duplicate the name of the framework when describing it, i.e. change KConfigWidgets provides widgets for confiugration dialogs. to Easy-to-use widgets for constructing config dialogs
144

I would probably drop "KDE" from here

145

Like above, drop the question and rewrite. You probably don't need this sentence in the first place anyways.

147–179

Like above, don't duplicate the name of the tools when describing them

180–182

Not sure I would have the HIG be just a "pro tip"

184–222

Again, inconsistent period usage and duplication of format name

216

Distro packaging probably shouldn't link to the appimage github.

224–226

Duplication of tool name

257–258

I would drop "KDE isn't the only community developing with Qt," "not just those by the KDE community," and drop duplication of tool name.

crusader updated this revision to Diff 76183.Feb 22 2020, 4:04 PM

identations changes

crusader edited the test plan for this revision. (Show Details)Feb 24 2020, 4:57 AM
crusader updated this revision to Diff 76255.Feb 24 2020, 4:59 AM

Made the changes as suggested by cblack. Not sure if this is what was expected. Pls review

cblack added inline comments.Feb 27 2020, 6:54 PM
develop.php
110

Drop Providing, to→for.

ognarb requested changes to this revision.Fri, Mar 6, 12:42 AM
ognarb added inline comments.
develop.php
92

Why was this part removed?

103

Use a bootstrap padding utility instead

This revision now requires changes to proceed.Fri, Mar 6, 12:42 AM