Move tasks from 3px to 2px
AbandonedPublic

Authored by niccolove on Feb 16 2020, 8:21 PM.

Details

Reviewers
None
Group Reviewers
VDG
Summary

This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124:

Test Plan

Before:


After:

Difference between inactive and minimized is preserved:

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
2px_tasks (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22551
Build 22569: arc lint + arc unit
niccolove created this revision.Feb 16 2020, 8:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 16 2020, 8:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 16 2020, 8:21 PM
niccolove edited the summary of this revision. (Show Details)Feb 16 2020, 8:23 PM
niccolove edited the test plan for this revision. (Show Details)
niccolove added a reviewer: VDG.
niccolove edited the test plan for this revision. (Show Details)Feb 16 2020, 8:26 PM
niccolove updated this revision to Diff 75798.Feb 16 2020, 8:27 PM

Used scour

niccolove planned changes to this revision.Feb 16 2020, 8:38 PM

I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed.

niccolove requested review of this revision.Feb 16 2020, 9:09 PM

Nope, that does not work. Let's stick to 2px.

Technical review:
This patch has hardcoded colors in it. Gotta fix that.


Visual review:

Personally I don't really see the point of it. This patch makes the line so thin that it's practically not even there anymore. At that point, we might as well just remove it. If the line is going to be there, I think it feels better with some visual weight.

I won't block this patch if everyone loves the proposed change though; that's just my opinion. :)

ndavis added a subscriber: ndavis.Feb 16 2020, 11:02 PM

I don't think it's really worth it to do this patch for the same reasons as Nate.

This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124

For the record, I use 3px lines in what I have done so far with that task.

With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme):

niccolove abandoned this revision.Wed, Mar 11, 12:31 PM

I'd actually prefer to make the task manager extend to panel borders.