This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124:
Details
- Reviewers
- None
- Group Reviewers
VDG
Before:
After:
Difference between inactive and minimized is preserved:
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- 2px_tasks (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22550 Build 22568: arc lint + arc unit
I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed.
Technical review:
This patch has hardcoded colors in it. Gotta fix that.
Visual review:
Personally I don't really see the point of it. This patch makes the line so thin that it's practically not even there anymore. At that point, we might as well just remove it. If the line is going to be there, I think it feels better with some visual weight.
I won't block this patch if everyone loves the proposed change though; that's just my opinion. :)
This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124
For the record, I use 3px lines in what I have done so far with that task.
With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme):