Restore capability of unavailable ports to be active, which was prevented
with 10ab204a62cf.
Enable port selection in case an unavailable port is active.
Details
Details
- Reviewers
drosca ngraham - Group Reviewers
Plasma - Commits
- R115:ada3385d04c3: [Applet]Improvements for unavailable port.
Before: Choosing an unavailable port from pavucontrol was impossible.
After: Activating an unavailable port is possible. Can test with D27422.
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- freeThePort (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22564 Build 22582: arc lint + arc unit
Comment Actions
That's a clever fix. Very nice how it solves the reporter's problem without changing the UI at all for everyone else who doesn't need it. No regressions found in testing.
What do you think; should we target 5.18.1 for this bugfix?
Comment Actions
...it solves the reporter's problem...
Not exactly. When an available port gets selected(or is active) port option will disappear again. Only enables complete port selection while an unavailable is the default.
Or has the code diverged between 5.18 and master too much?
Yeah, too many patches. In master, you know, we changed the UI, limited the port selection... :D
| applet/contents/ui/ListItemBase.qml | ||
|---|---|---|
| 357 | I wanted to do this change, but this is old code from 5.17. I believe that translated history must exist, and will automatically be used. | |
| applet/contents/ui/ListItemBase.qml | ||
|---|---|---|
| 357 | Better to change it now to avoid the string puzzle entirely IMO | |