fix: reset doctor output color before exiting
ClosedPublic

Authored by z3ntu on Feb 13 2020, 8:11 PM.

Details

Summary

Without this patch the blue from the "primary" output 'leaks' into the
prompt of some shells (e.g. busybox ash).

Test Plan

Run "kscreen-doctor -o" in ash and observe that the prompt isn't blue anymore afterwards.

Diff Detail

Repository
R110 KScreen Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22448
Build 22466: arc lint + arc unit
z3ntu created this revision.Feb 13 2020, 8:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 8:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
z3ntu requested review of this revision.Feb 13 2020, 8:11 PM
davidedmundson accepted this revision.Feb 13 2020, 8:33 PM
This revision is now accepted and ready to land.Feb 13 2020, 8:33 PM

Please respect the Commit Message Guideline when pushing the change:
https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22

z3ntu added a comment.Feb 13 2020, 8:46 PM

Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.

Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.

Scopes are only optional. Since there is only one directory for the doctor and not many patches I didn't add an extra scope for it. I would recommend for the commit header:

fix: reset doctor output color before exiting

Thank you.

z3ntu updated this revision to Diff 75643.Feb 13 2020, 9:01 PM

Change commit message

romangg retitled this revision from kscreen-doctor: reset color before exiting to fix: reset doctor output color before exiting.Feb 13 2020, 9:06 PM

Do you have commit rights? Otherwise I need your name and email for author information.

z3ntu added a comment.Feb 13 2020, 9:13 PM

No I don't have commit rights.
Luca Weiss luca@z3ntu.xyz (but isn't this information already as commit author?)

True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account

cfeck added a comment.Feb 13 2020, 9:36 PM

Oh, okey. That was just misleading.

I also suggest to ask for commit rights then.

cfeck added a comment.Feb 13 2020, 9:38 PM

Since this patch isn't critical, it would make a perfect candidate for your first steps with committing :)

Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff

So Luca, you need to write an additional one. ;)

This revision was automatically updated to reflect the committed changes.