Without this patch the blue from the "primary" output 'leaks' into the
prompt of some shells (e.g. busybox ash).
Details
Run "kscreen-doctor -o" in ash and observe that the prompt isn't blue anymore afterwards.
Diff Detail
- Repository
- R110 KScreen Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Please respect the Commit Message Guideline when pushing the change:
https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22
Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.
Scopes are only optional. Since there is only one directory for the doctor and not many patches I didn't add an extra scope for it. I would recommend for the commit header:
fix: reset doctor output color before exiting
Thank you.
Do you have commit rights? Otherwise I need your name and email for author information.
No I don't have commit rights.
Luca Weiss luca@z3ntu.xyz (but isn't this information already as commit author?)
True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account
According to https://phabricator.kde.org/R982:8dffcc64d2aec4041129d67809839f136fec080a you have commit rights?
Merged by Carl Schwan 3 days ago
https://invent.kde.org/websites/plasma-mobile-org/merge_requests/39
No I don't.
Since this patch isn't critical, it would make a perfect candidate for your first steps with committing :)
Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff
So Luca, you need to write an additional one. ;)