Restore former position of "Create New" menu item in viewport context menu
ClosedPublic

Authored by ngraham on Feb 9 2020, 4:05 PM.

Details

Summary

I've seem various complaints from users about the fact that the Create New... menu
item in the viewport context menu is now below Open With item. All the other
changes to menus seem to have been well-received but this one has garnered criticism.
Looking through D23757 and D11884, I can't actually see that this was intentional, so
it might even be a bug.

Either way, this patch restores the old position of the Create New menu items at
the top of the Viewport context menu.

BUG: 417640
FIXED-IN: 20.04.0

Test Plan

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 9 2020, 4:05 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptFeb 9 2020, 4:05 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 9 2020, 4:05 PM
ndavis accepted this revision.Feb 9 2020, 4:18 PM
This revision is now accepted and ready to land.Feb 9 2020, 4:18 PM
markuss added a subscriber: markuss.Feb 9 2020, 5:57 PM

I think Open With on top just makes more sense, especially with Create New now grouped with other file creation actions (Paste,..).

It's the kind of muscle memory that adjusts over time. No biggie to adapt.

It makes more sense from a bare consistency perspective, however we should take into account what people are more likely to do when they right-click on the view background. We don't have telemetry of course (maybe it's time to adopt KUserFeedback in Dolphin!), but user feedback has indicated that a lot of people are much more likely to want to create a folder or file than they are to open the folder itself in another app.

ngraham edited the summary of this revision. (Show Details)Feb 14 2020, 3:06 PM
ngraham edited the summary of this revision. (Show Details)Feb 14 2020, 3:49 PM
This revision was automatically updated to reflect the committed changes.