update travel-family icons
ClosedPublic

Authored by mbruchert on Feb 6 2020, 10:26 AM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:cf10c681f350: update travel-family icons
Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mbruchert created this revision.Feb 6 2020, 10:26 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 6 2020, 10:26 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Feb 6 2020, 10:26 AM
mbruchert updated this revision to Diff 75092.Feb 6 2020, 10:28 AM

optimize svgs

ndavis requested changes to this revision.Feb 6 2020, 11:47 AM
ndavis added a subscriber: ndavis.

Whoops, looks like you accidentally made them 48x48 mm instead of 48x48 px :)

You'll need to work on the pixel alignment a bit because shrinking them down to the correct size without changing any proportions causes some blurriness.

This revision now requires changes to proceed.Feb 6 2020, 11:47 AM

Please add some screenshots

mbruchert updated this revision to Diff 75114.Feb 6 2020, 5:45 PM
  • screenshot icon
ngraham added a subscriber: ngraham.Feb 6 2020, 5:46 PM

I think he meant to add some screenshots to the Test Plan section of this patch so people can see the new icons without having to apply it. :)

mbruchert updated this revision to Diff 75121.Feb 6 2020, 6:04 PM
  • fix everything(px)
mbruchert updated this revision to Diff 75124.Feb 6 2020, 6:23 PM

fix everything for real

nicolasfella edited the test plan for this revision. (Show Details)Feb 6 2020, 6:34 PM
ndavis added a comment.EditedFeb 6 2020, 6:38 PM

Much better. Now the margins need to be 4px rather than 3px. If you haven't already, make sure you read the HIG section on icons and the workflow tips wiki page it links to.
https://hig.kde.org/style/icons/index.html
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

I'm not going to be picky about diagonal lines in this case, but just be aware of the technique for making pixel perfect 45 degree lines in the workflow tips page.

In the KTrip icon, the overhead cable and the horizontal line connecting the tram to the cable are out of alignment with the pixel grid. Any strokes should be converted to paths (sometimes SVG renderers make strokes look jagged).

I think the air plane in the KDE Itinerary icon is too small. It would probably be a good idea to enlarge the plane and cut off any parts outside of the icon, similar to the KTrip icon.

It may or may not be good to remove the blue background objects. They add a bit of flavor, but they're also a source of complexity that doesn't really enhance the meaningfulness of the icon.

mbruchert updated this revision to Diff 75130.Feb 6 2020, 7:38 PM
  • screenshot icon
  • 4px border
mbruchert updated this revision to Diff 75131.Feb 6 2020, 7:39 PM

remove accidentially commited files

mbruchert updated this revision to Diff 75132.Feb 6 2020, 7:42 PM

remove accidentially commited icons

ndavis accepted this revision.Feb 6 2020, 8:06 PM

This looks ready to go. I'll do some additional optimization later.

This revision is now accepted and ready to land.Feb 6 2020, 8:06 PM
This revision was automatically updated to reflect the committed changes.

These are lovely icons, BTW. Very nice work.

Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere.