Differential D27183

Port Application Page's form layout to Kirigami FormLayout
ClosedPublic
Actions

Authored by ngraham on Feb 6 2020, 5:21 AM.

Details

Reviewers
apol
ndavis
Group Reviewers
VDG
Discover Software Store
Commits
R134:40742348cf05: Port Application Page's form layout to Kirigami FormLayout
Summary

This simplifies the code, allows the layout to have a mobile-appropriate appearance
when there's not much horizontal space, and it's more semantically correct.

Test Plan

There is one regression I haven't figured out: sometimes long labels get inappropriately
elided.

Diff Detail

Repository
R134 Discover Software Store
Branch
port-to-formlayout (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22112
Build 22130: arc lint + arc unit
ngraham created this revision.Feb 6 2020, 5:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2020, 5:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 6 2020, 5:21 AM
ndavis accepted this revision.Feb 6 2020, 5:53 AM
This revision is now accepted and ready to land.Feb 6 2020, 5:53 AM
apol accepted this revision.Feb 6 2020, 10:05 AM
ngraham added a comment.Feb 6 2020, 6:00 PM

Looks like the elision issue could be an issue in FormLayout itself. I'll follow up.

Closed by commit R134:40742348cf05: Port Application Page's form layout to Kirigami FormLayout (authored by ngraham). · Explain WhyFeb 6 2020, 6:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationPage.qml (71 lines)

Diff 75079

View Options

discover/qml/ApplicationPage.qml

Loading...