Differential D27171

kcms/kwinoptions : convert Advanced part to KConfigXT
ClosedPublic
Actions

Authored by meven on Feb 5 2020, 3:32 PM.

Tags

Subscribers

Details

Reviewers

ervin
bport
crossi
zzag

Group Reviewers

Commits

R108:3f7fa8e47b53: kcms/kwinoptions : convert Advanced part to KConfigXT

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

meven created this revision.Feb 5 2020, 3:32 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2020, 3:32 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

meven requested review of this revision.Feb 5 2020, 3:32 PM

Harbormaster completed remote builds in B22094: Diff 75055.Feb 5 2020, 3:32 PM

s/bool/Bool

Harbormaster completed remote builds in B22097: Diff 75058.Feb 5 2020, 3:36 PM

meven added reviewers: bport, crossi, zzag.Feb 5 2020, 3:42 PM

zzag added inline comments.Feb 5 2020, 3:50 PM

kcmkwin/kwinoptions/main.cpp
79	KWin requires C++14 so you can use `qOverload()`.

Use qOverload<>() instead of QOverload<>::of

Harbormaster completed remote builds in B22100: Diff 75061.Feb 5 2020, 4:19 PM

meven added inline comments.Feb 5 2020, 4:20 PM

kcmkwin/kwinoptions/windows.cpp
410	Btw this was needed for my previous patch but it slipped through.

zzag accepted this revision.Feb 5 2020, 7:39 PM

This revision is now accepted and ready to land.Feb 5 2020, 7:39 PM

meven added inline comments.Feb 6 2020, 8:06 AM

kcmkwin/kwinoptions/windows.cpp
364–371	I wish we had a way to have the enum's user label in kcfg files

Closed by commit R108:3f7fa8e47b53: kcms/kwinoptions : convert Advanced part to KConfigXT (authored by meven). · Explain WhyFeb 6 2020, 8:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcmkwin/kwinoptions/advanced.ui (14 lines)
M			kcmkwin/kwinoptions/kwinoptions_settings.kcfg (26 lines)
M			kcmkwin/kwinoptions/main.cpp (20 lines)
M			kcmkwin/kwinoptions/windows.h (19 lines)
M			kcmkwin/kwinoptions/windows.cpp (104 lines)

Diff 75084

kcmkwin/kwinoptions/advanced.ui

Loading...

kcmkwin/kwinoptions/kwinoptions_settings.kcfg

Loading...

kcmkwin/kwinoptions/main.cpp

Loading...

kcmkwin/kwinoptions/windows.h

Loading...

kcmkwin/kwinoptions/windows.cpp

Loading...