- Make default button work
- Move connection from cpp to .ui
- Slight label change
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- arcpatch-D27127
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22585 Build 22603: arc lint + arc unit
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #74925) | Missing this as parent, this is leaked. Also I'd likely move that in the ctor initialization list (same thing for m_devices actually, maybe in another patch, your call). |
| 114 ↗ | (On Diff #74925) | I'd store the result of the automountEnabled call in an intermediate variable, just to make things more readable. |
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 84 | We can also change kcfgc to add parent in constructor | |
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #74925) | I tend to consider this as a step back to be honest. Singletons tend to be more trouble down the line when something goes wrong. |
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #74925) | Please beware this will make my patch quite a lot more intrusive, DeviceModel for instance, will need a field to keep some reference to the AutomounterSettings |
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #74925) | Sure, moving away from a singleton is always intrusive (just like moving away from a global variable which it is really). Let's aim for it in a different specific patch. |
| solid-device-automounter/kcm/DeviceAutomounterKCM.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #74925) | Just waiting for this review then, I am preparing the next patch |