Fix duplicate results for sessions, simplify and optimize
ClosedPublic

Authored by alex on Feb 2 2020, 7:37 PM.

Details

Summary

The sessions are now only loaded when the plugin is initialized or the folder changes.
Additionally the option to search for a session just by the name has been removed,
because Kate itself provides this functionality (demonstated in screenshots).

Test Plan

Create sessions, they should show up like in the last two screenshots.
After testing this create/edit/delete sessions, the changes should be automatically applied.
Before:


After:

Search with "kate" prefix should work as before:

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alex created this revision.Feb 2 2020, 7:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 2 2020, 7:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Feb 2 2020, 7:37 PM
alex updated this revision to Diff 74875.Feb 2 2020, 7:45 PM

Minor formatting improvements

alex added a reviewer: Plasma.Feb 2 2020, 7:46 PM
ngraham added a reviewer: Kate.Feb 3 2020, 9:40 PM
cullmann accepted this revision.Feb 9 2020, 11:35 AM
cullmann added a subscriber: cullmann.

Improved output seems fine for me, thanks for taking care.

This revision is now accepted and ready to land.Feb 9 2020, 11:35 AM

Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc.

Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=)

alex added a comment.Feb 9 2020, 11:38 AM

No problem, thanks for reviewing :-)

This revision was automatically updated to reflect the committed changes.