Differential D27080

Don't warn for invalid plugin metata
ClosedPublic
Actions

Authored by ngraham on Jan 31 2020, 10:53 PM.

Details

Reviewers
mart
apol
Group Reviewers
Plasma
Commits
R242:b76b908e1056: Don't warn for invalid plugin metata
Summary

See explanation in https://bugs.kde.org/show_bug.cgi?id=412464

BUG: 412464
FIXED-IN: 5.67

Test Plan

restart plasmashell, see way less useless warning spam

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 31 2020, 10:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 31 2020, 10:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 31 2020, 10:53 PM
alex added a subscriber: alex.Feb 1 2020, 11:36 AM
apol added a subscriber: apol.Feb 3 2020, 5:10 PM

Change to qDebug? this is just a result to an ugly workaround and is just a symptom of also a performance issue. Silencing it only perpetuates the issue.

ngraham updated this revision to Diff 75149.Feb 7 2020, 5:08 AM

Use qCDebug() instead of removing it

apol accepted this revision.Feb 7 2020, 9:38 AM
This revision is now accepted and ready to land.Feb 7 2020, 9:38 AM
Closed by commit R242:b76b908e1056: Don't warn for invalid plugin metata (authored by ngraham). · Explain WhyFeb 7 2020, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/pluginloader.cpp (2 lines)

Diff 75164

View Options

src/plasma/pluginloader.cpp

Loading...