Differential D27067

Change "AutoSkip" to "Skip All"
ClosedPublic
Actions

Authored by ngraham on Jan 31 2020, 1:50 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
VDG
Commits
R241:2c84f4b1c8fb: Change "AutoSkip" to "Skip All"
Summary

"AutoSkip" is not a word and makes it unclear what the button actually does.

BUG: 416964
FIXED-IN: 5.68

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 31 2020, 1:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 31 2020, 1:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 31 2020, 1:50 PM
broulik added a subscriber: broulik.Jan 31 2020, 1:53 PM

+1 (also for considering the string freeze :)

I think we should add some mnemonics, i.e. "&Skip" and "Skip &all"

ngraham added a comment.Jan 31 2020, 2:16 PM

Sure, in another patch. :)

apol accepted this revision.Feb 7 2020, 9:47 AM
This revision is now accepted and ready to land.Feb 7 2020, 9:47 AM
Closed by commit R241:2c84f4b1c8fb: Change "AutoSkip" to "Skip All" (authored by ngraham). · Explain WhyFeb 7 2020, 1:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/skipdialog.cpp (2 lines)

Diff 75161

View Options

src/widgets/skipdialog.cpp

Loading...