details see https://phabricator.kde.org/T12594
Details
Details
- Reviewers
ngraham ndavis tysontan - Group Reviewers
VDG - Commits
- R266:b5df044e6614: create Breeze style Kate icon based on new design by Tyson Tan
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21873 Build 21891: arc lint + arc unit
Comment Actions
I tried to follow the guide on https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips and what was said in https://phabricator.kde.org/T12594
I used the kate-source-derivatives.svg from that task as input, set the size to 48 (4 pixel margin inside) and piped it afterwards through scour (as inkscape optimize did fail for me because of some python issues).
Comment Actions
Please also replace icons-dark/apps/48/kate.svg
| icons/apps/48/kate.svg | ||
|---|---|---|
| 47 ↗ | (On Diff #74719) | Oops, there's a PNG inside the SVG! This should be a pure SVG. |
Comment Actions
2 questions:
- should I use the same icon for dark?
- what to do with the PNG part? Can this just be stripped? And how? ;=)
Sorry for the noob questions, but SVG-wise I have no ideas ;=)
Comment Actions
Ok, I just tried to cut the PNG part, that seems to be ok.
For the other icons, I see, there are even more in other subdirs:
cullmann … kde src breeze-icons find . -name "kate.svg" master
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svg
What to do with them?
Comment Actions
Thanks, much better now.
Yep.
For the other icons, I see, there are even more in other subdirs:
cullmann … kde src breeze-icons find . -name "kate.svg" master
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svgWhat to do with them?
Since there are already versions of the old icon in multiple sizes, we have two options:
- Replace them all with appropriate versions for those sizes, which may be easy seeing as @tysontan already made them
- Remove them all.
Comment Actions
For the other icons, I see, there are even more in other subdirs:
cullmann … kde src breeze-icons find . -name "kate.svg" master
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svgWhat to do with them?
Since there are already versions of the old icon in multiple sizes, we have two options:
- Replace them all with appropriate versions for those sizes, which may be easy seeing as @tysontan already made them
- Remove them all.
The smaller versions Tyson has submitted in the task look all like just PNG exports of the SVG.
(I generated them via ksvgtopng in kate.git, see https://invent.kde.org/kde/kate/tree/master/kate/icons )
I think for breeze we can just remove the extra SVGs as the new icons (IMHO) scales well.
Comment Actions
LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run the icon through an SVG optimizer. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization.
Personally I use scour, invoked as indicated on that wiki page.
Comment Actions
Ok ;=)
Actually, I did already "scour" this file as described on that page. For me scour no longer does something on it, if I don't use it wrong.
Comment Actions
LGTM
If you're not sure, use scour because it's the least likely to screw anything up. As long as the code is formatted well and not filled with useless noise, it's fine if it isn't as small as it could be.
I optimized it a bit more with SVG Cleaner, used viewbox only for setting the canvas size and deleted a big invisible rectangle. Use this if you want:
Comment Actions
Shipit! Shipit good! Just shipit!
If the icon comes along, you must shipit
Before pixels set out too long, you must ship it
When something's going wrong right, you must ship it
Now shipit! It's not too late!