create Breeze style Kate icon based on new design by Tyson Tan
ClosedPublic

Authored by cullmann on Thu, Jan 30, 6:21 PM.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Thu, Jan 30, 6:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Jan 30, 6:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cullmann requested review of this revision.Thu, Jan 30, 6:21 PM

I tried to follow the guide on https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips and what was said in https://phabricator.kde.org/T12594

I used the kate-source-derivatives.svg from that task as input, set the size to 48 (4 pixel margin inside) and piped it afterwards through scour (as inkscape optimize did fail for me because of some python issues).

Please also replace icons-dark/apps/48/kate.svg

icons/apps/48/kate.svg
47

Oops, there's a PNG inside the SVG! This should be a pure SVG.

ngraham requested changes to this revision.Thu, Jan 30, 6:30 PM
This revision now requires changes to proceed.Thu, Jan 30, 6:30 PM

2 questions:

  1. should I use the same icon for dark?
  2. what to do with the PNG part? Can this just be stripped? And how? ;=)

Sorry for the noob questions, but SVG-wise I have no ideas ;=)

2 questions:

  1. should I use the same icon for dark?
  2. what to do with the PNG part? Can this just be stripped? And how? ;=)

    Sorry for the noob questions, but SVG-wise I have no ideas ;=)

Ok, I just tried to cut the PNG part, that seems to be ok.

For the other icons, I see, there are even more in other subdirs:

 cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"    master 
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svg

What to do with them?

cullmann updated this revision to Diff 74720.Thu, Jan 30, 6:41 PM
  • cut PNG part from kate.svg + update dark icon, too
cullmann marked an inline comment as done.Thu, Jan 30, 6:41 PM

PNG part is gone, seems to have no effect.

Thanks, much better now.

2 questions:

  1. should I use the same icon for dark?

Yep.

For the other icons, I see, there are even more in other subdirs:

 cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"    master 
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svg

What to do with them?

Since there are already versions of the old icon in multiple sizes, we have two options:

  1. Replace them all with appropriate versions for those sizes, which may be easy seeing as @tysontan already made them
  2. Remove them all.

For the other icons, I see, there are even more in other subdirs:

 cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"    master 
./icons/apps/32/kate.svg
./icons/apps/64/kate.svg
./icons/apps/16/kate.svg
./icons/apps/22/kate.svg
./icons/apps/48/kate.svg
./icons-dark/apps/32/kate.svg
./icons-dark/apps/64/kate.svg
./icons-dark/apps/16/kate.svg
./icons-dark/apps/22/kate.svg
./icons-dark/apps/48/kate.svg

What to do with them?

Since there are already versions of the old icon in multiple sizes, we have two options:

  1. Replace them all with appropriate versions for those sizes, which may be easy seeing as @tysontan already made them
  2. Remove them all.

The smaller versions Tyson has submitted in the task look all like just PNG exports of the SVG.
(I generated them via ksvgtopng in kate.git, see https://invent.kde.org/kde/kate/tree/master/kate/icons )

I think for breeze we can just remove the extra SVGs as the new icons (IMHO) scales well.

cullmann updated this revision to Diff 74727.Thu, Jan 30, 8:20 PM
  • delete different sized icons, new icon scales well enough
ngraham accepted this revision as: ngraham.Thu, Jan 30, 8:27 PM

LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run the icon through an SVG optimizer. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization.

Personally I use scour, invoked as indicated on that wiki page.

LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run the icon through an SVG optimizer. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization.

Personally I use scour, invoked as indicated on that wiki page.

Ok ;=)

Actually, I did already "scour" this file as described on that page. For me scour no longer does something on it, if I don't use it wrong.

ndavis accepted this revision.Thu, Jan 30, 8:43 PM

LGTM

If you're not sure, use scour because it's the least likely to screw anything up. As long as the code is formatted well and not filled with useless noise, it's fine if it isn't as small as it could be.

I optimized it a bit more with SVG Cleaner, used viewbox only for setting the canvas size and deleted a big invisible rectangle. Use this if you want:

This revision is now accepted and ready to land.Thu, Jan 30, 8:43 PM
cullmann updated this revision to Diff 74728.Thu, Jan 30, 8:50 PM
  • use optimized version by ndavis
ngraham accepted this revision.Thu, Jan 30, 9:15 PM

Shipit! Shipit good! Just shipit!

If the icon comes along, you must shipit

Before pixels set out too long, you must ship it

When something's going wrong right, you must ship it

Now shipit! It's not too late!

This revision was automatically updated to reflect the committed changes.