Differential D27039

[KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme
ClosedPublic
Actions

Authored by davidre on Jan 30 2020, 3:47 PM.

Details

Reviewers
aacid
anthonyfieroni
apol
Group Reviewers
Frameworks
Commits
R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets to the correct one from the current…
Summary

KMessageWidget has to rely on hardcoded colors because it's in a Tier 1 framework.
However after determining its color it will give the style a chance to set a
better fitting color by calling polish. So set it's color to the appropriate
one from the current color scheme.

Test Plan

KmessageWidget follows Color Scheme




Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Jan 30 2020, 3:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 30 2020, 3:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Jan 30 2020, 3:47 PM
davidre updated this revision to Diff 74713.Jan 30 2020, 5:09 PM

Fix code style

aacid added a comment.Feb 22 2020, 4:11 PM

Any particular reason you added me?

anthonyfieroni accepted this revision.Feb 24 2020, 7:23 AM

No, just to not reviewed only by me.

This revision is now accepted and ready to land.Feb 24 2020, 7:23 AM
apol accepted this revision.Feb 24 2020, 4:11 PM
Closed by commit R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets to the correct one from the current… (authored by davidre). · Explain WhyFeb 25 2020, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (22 lines)

Diff 76410

View Options

src/kstyle/kstyle.cpp

Loading...