| bcooksley |
| Frameworks | |
| KNewStuff |
Rather than suggest using dko for provider files, we should be
suggesting autoconfig.k.o, which is a more capable service.
This is hopefully going to help in alleviating the overload on
the download.kde.org service, which does not handle the load as
well as autoconfig.kde.org does (and can't be fixed due to legacy).
See also https://marc.info/?l=kde-core-devel&m=158037601132219&w=2
for further details on the situation.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 22086 | |
| Build 22104: arc lint + arc unit |
As suggested by frinring, do not suggest setting a ProvidersUrl unless
it is actually needed.
| src/core/cache.cpp | ||
|---|---|---|
| 163 | We use https everywhere these days | |
| src/core/cache.cpp | ||
|---|---|---|
| 163 | Yes, quite, we certainly do. (i'm also wondering if this is really something that wants changing or not, as it's... in a bit that loads KNS2 cache files... from KDE3) | |
Thanks to broulik for noticing (or making me notice) this
| src/core/cache.cpp | ||
|---|---|---|
| 163 | Yup, this wants to be left alone... i'll add a little comment to that effect. | |
| tests/khotnewstuff.knsrc | ||
|---|---|---|
| 2 | Shouldn't it be in https ? | |
| tests/khotnewstuff.knsrc | ||
|---|---|---|
| 2 | Yes, this should be https - the server will redirect to https (which sets HSTS headers) in any case. | |
| tests/khotnewstuff.knsrc | ||
|---|---|---|
| 2 | Better set this to https then, to make it explicit and not relying on server expectations. | |
| tests/khotnewstuff.knsrc | ||
|---|---|---|
| 2 | Quite - that redirection isn't what these test knsrc files are supposed to be for, so good to get that fixed. | |
During some cleanup and addition, i realised it was silly to have
the documentation for knsrc files in the widgets bits, and in two
places. In addition, those places were both at least a bit wrong,
or outdated, and needed fixing anyway, so... consolidate all that
into the README.md file, as it's fairly central anyway. More could
reasonably be done with that section, but this is already better.