Replace KoToolButton with KoToolAction
ClosedPublic
Actions

Authored by kossebau on Aug 25 2015, 4:36 PM.

Details

Reviewers

Commits

Summary

change KoToolBox to use own buttons, made from new KoToolBoxButton which wires up to the KoToolAction
change KoModeBox to directly use KoToolAction instead of the formerly used hack with the hidden QToolButton object of KoToolButton
move creation of tooltip with added shortcut from ToolHelper to KoToolBox
fixes new shortcuts having not been forwarded to any instances of KoToolBox, only the latest created
fixes KoModeBox showing tooltips (with shortcuts) as tab labels

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau retitled this revision from to Replace KoToolButton with KoToolAction.

kossebau updated this object.

kossebau edited the test plan for this revision. (Show Details)

kossebau added reviewers: rempt, boemann.

It seems to work in Krita, I tested with two different main windows and changing the shortcuts, and that was fine.

This revision is now accepted and ready to land.Aug 26 2015, 7:23 AM

boemann edited edge metadata.

abrahams edited edge metadata.

This revision was automatically updated to reflect the committed changes.

		Path
M		libs/flake/KoToolManager.h (59 lines)
M		libs/flake/KoToolManager.cpp (104 lines)
M		libs/flake/KoToolManager_p.h (40 lines)
M		libs/flake/KoToolManager_p.cpp (113 lines)
M		libs/widgets/CMakeLists.txt (1 line)
M		libs/widgets/KoModeBox.cpp (96 lines)
M		libs/widgets/KoModeBox_p.h (36 lines)
M		libs/widgets/KoToolBox.cpp (40 lines)
A	M	libs/widgets/KoToolBoxButton.cpp (56 lines)
A	M	libs/widgets/KoToolBoxButton_p.h (40 lines)
M		libs/widgets/KoToolBox_p.h (7 lines)