Replace KoToolButton with KoToolAction
ClosedPublic

Authored by kossebau on Aug 25 2015, 4:36 PM.

Details

Summary
  • change KoToolBox to use own buttons, made from new KoToolBoxButton which wires up to the KoToolAction
  • change KoModeBox to directly use KoToolAction instead of the formerly used hack with the hidden QToolButton object of KoToolButton
  • move creation of tooltip with added shortcut from ToolHelper to KoToolBox
  • fixes new shortcuts having not been forwarded to any instances of KoToolBox, only the latest created
  • fixes KoModeBox showing tooltips (with shortcuts) as tab labels

Diff Detail

Repository
R8 Calligra
Branch
improveToolBoxes
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 604.Aug 25 2015, 4:36 PM
kossebau retitled this revision from to Replace KoToolButton with KoToolAction.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: rempt, boemann.
kossebau added a subscriber: Calligra-Devel-list.
rempt accepted this revision.Aug 26 2015, 7:23 AM
rempt edited edge metadata.

It seems to work in Krita, I tested with two different main windows and changing the shortcuts, and that was fine.

This revision is now accepted and ready to land.Aug 26 2015, 7:23 AM
boemann accepted this revision.Aug 26 2015, 4:00 PM
boemann edited edge metadata.
abrahams accepted this revision.Aug 26 2015, 4:32 PM
abrahams edited edge metadata.
This revision was automatically updated to reflect the committed changes.