On a related note, can you make sure the properties of EffectWindow are up to date with these geometry changes. It only has 2 geometries, which isn't nearly enough!

This revision is now accepted and ready to land.Jan 23 2020, 11:51 AM

In D26864#599543, @davidedmundson wrote:

On a related note, can you make sure the properties of EffectWindow are up to date with these geometry changes. It only has 2 geometries, which isn't nearly enough!

Aren't they up to date already?

zzag added a dependent revision: D26905: [effects/maximize] Use windowFrameGeometryChanged.Jan 25 2020, 12:41 AM

zzag added a dependent revision: D26906: [effects/thumbnailaside] Use windowFrameGeometryChanged.Jan 25 2020, 12:45 AM

zzag added a dependent revision: D26907: [effects/presentwindows] Use windowFrameGeometryChanged.Jan 25 2020, 12:48 AM

zzag added a dependent revision: D26908: [effects/desktopgrid] Use windowFrameGeometryChanged.

zzag added a dependent revision: D26909: [effects/snaphelper] Use windowFrameGeometryChanged.Jan 25 2020, 12:52 AM

Closed by commit R108:00f4f88f6512: Expose frameGeometryChanged signal to effects (authored by zzag). · Explain WhyFeb 12 2020, 9:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			effects.h (1 line)
M			effects.cpp (10 lines)
M			libkwineffects/kwineffects.h (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74199	70c6f7a		Jan 23 2020, 10:08 AM	★	★
Diff 2	74201	70c6f7a	s/@see/@since/	Jan 23 2020, 10:15 AM	★	★
Diff 3	75520	15af09c	R108:00f4f88f65122d6ed1eaca4f2f54f6c6d424bc44	Feb 12 2020, 8:52 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
85684c98a2d7	5e95554abefd	70c6f7a363c8	Vlad Zahorodnii	Expose frameGeometryChanged signal to effects	Jan 21 2020, 4:27 PM

Status	Author	Revision
Closed	zzag	D26865 [effects/morphingpopups] Start animation on windowFrameGeometryChanged
Closed	zzag	D26905 [effects/maximize] Use windowFrameGeometryChanged
Closed	zzag	D26906 [effects/thumbnailaside] Use windowFrameGeometryChanged
Closed	zzag	D26907 [effects/presentwindows] Use windowFrameGeometryChanged
Closed	zzag	D26908 [effects/desktopgrid] Use windowFrameGeometryChanged
Closed	zzag	D26909 [effects/snaphelper] Use windowFrameGeometryChanged
Closed	zzag	D26864 Expose frameGeometryChanged signal to effects
Closed	zzag	D26863 Introduce Toplevel::frameGeometryChanged signal

Diff 74199

View Options

effects.h

View Options

effects.cpp

View Options

libkwineffects/kwineffects.h

Expose frameGeometryChanged signal to effectsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 74199

effects.h

effects.cpp

libkwineffects/kwineffects.h

Expose frameGeometryChanged signal to effects
ClosedPublic
Actions

Revision Contents
Changeset List