Introduce Toplevel::frameGeometryChanged signal
15af09c70a89
Actions

Authored by zzag on Feb 5 2020, 9:28 AM.

Description

Introduce Toplevel::frameGeometryChanged signal

Summary:
Currently we have two signals that are emitted when the Toplevel's geometry
changes - geometryShapeChanged() and geometryChanged(). The former signal
is used primarily to invalidate cached window quads and the latter is
sort of emitted when the frame geometry changes. But it's not that easy. We
have a bunch of connects that link those signals together...

The worst part about all of this is that the window quads cache gets
invalidated every time a geometry update occurs, for example when user
moves a window around on the screen.

This change introduces a new signal and deprecates the existing geometryChanged
signal. frameGeometryChanged is similar to geometryChanged except that it is
emitted when an _actual_ geometry change has occurred.

We do still emit geometryShapeChanged signal. However, in long term, we
need to get rid of this signal or come up with something that makes sense
and doesn't require us to waste computational resources.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, romangg, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D26863

Details

Committed

zzag	Feb 12 2020, 8:52 AM

Reviewer

KWin

Differential Revision

D26863: Introduce Toplevel::frameGeometryChanged signal

Parents

R108:dd96e444ddfe: Merge branch 'Plasma/5.18'

Branches

Unknown

Tags

Unknown

zzag committed R108:15af09c70a89: Introduce Toplevel::frameGeometryChanged signal (authored by zzag).Feb 12 2020, 8:52 AM

Changes (23)

				Path	Packages
	M			abstract_client.cpp
	M			abstract_client.h
	M			autotests/integration/activation_test.cpp
	M			autotests/integration/effects/maximize_animation_test.cpp
	M			autotests/integration/maximize_test.cpp
	M			autotests/integration/move_resize_window_test.cpp
	M			autotests/integration/plasma_surface_test.cpp
	M			autotests/integration/quick_tiling_test.cpp
	M			autotests/integration/struts_test.cpp
	M			autotests/integration/transient_placement.cpp
	M			autotests/integration/xdgshellclient_rules_test.cpp
	M			autotests/integration/xdgshellclient_test.cpp
	M			decorations/decoratedclient.cpp
	M			events.cpp
	M			internal_client.cpp
	M			pointer_input.cpp
	M			shadow.cpp
	M			toplevel.cpp
	M			toplevel.h
	M			touch_input.cpp
	M			unmanaged.cpp
	M			x11client.cpp
	M			xdgshellclient.cpp

Introduce Toplevel::frameGeometryChanged signal15af09c70a89Actions

Description

Details

Changes (23)

R108:15af09c70a89

abstract_client.cpp

abstract_client.h

autotests/integration/activation_test.cpp

autotests/integration/effects/maximize_animation_test.cpp

autotests/integration/maximize_test.cpp

autotests/integration/move_resize_window_test.cpp

autotests/integration/plasma_surface_test.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/transient_placement.cpp

autotests/integration/xdgshellclient_rules_test.cpp

autotests/integration/xdgshellclient_test.cpp

decorations/decoratedclient.cpp

events.cpp

internal_client.cpp

pointer_input.cpp

shadow.cpp

toplevel.cpp

toplevel.h

touch_input.cpp

unmanaged.cpp

x11client.cpp

xdgshellclient.cpp

Introduce Toplevel::frameGeometryChanged signal
15af09c70a89
Actions