Differential D26864

Expose frameGeometryChanged signal to effects
ClosedPublic
Actions

Authored by zzag on Jan 23 2020, 10:08 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:00f4f88f6512: Expose frameGeometryChanged signal to effects

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 23 2020, 10:08 AM
Restricted Application added a project: KWin. · View Herald TranscriptJan 23 2020, 10:08 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 23 2020, 10:08 AM
zzag updated this revision to Diff 74201.Jan 23 2020, 10:16 AM

s/@see/@since/

davidedmundson accepted this revision.Jan 23 2020, 11:51 AM
davidedmundson added a subscriber: davidedmundson.

Makes sense.

On a related note, can you make sure the properties of EffectWindow are up to date with these geometry changes. It only has 2 geometries, which isn't nearly enough!

This revision is now accepted and ready to land.Jan 23 2020, 11:51 AM
zzag added a comment.Jan 23 2020, 1:03 PM
In D26864#599543, @davidedmundson wrote:

On a related note, can you make sure the properties of EffectWindow are up to date with these geometry changes. It only has 2 geometries, which isn't nearly enough!

Aren't they up to date already?

Closed by commit R108:00f4f88f6512: Expose frameGeometryChanged signal to effects (authored by zzag). · Explain WhyFeb 12 2020, 9:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.h (1 line)
Meffects.cpp (10 lines)
Mlibkwineffects/kwineffects.h (7 lines)

Diff 75520

View Options

effects.h

Loading...
View Options

effects.cpp

Loading...
View Options

libkwineffects/kwineffects.h

Loading...