demote plugin load errors from warning to debug level + reword

Authored by sitter on Jan 22 2020, 12:36 PM.



while they are errors from our POV the callers POV may be that
they'll simply try another name. with the previous behavior
we would always end up printing the message because warnings
are visible by default and then on top of that the warning
would use the word error.

this lead to users getting confused about the actual impact:

when the caller has additional handling:

the latter ought to always be the case as far as error reporting
goes because the class documentation even suggests as much
in its example snippet.

as a result of all this it seems way more appropriate to
consider this a debug message on a kcoreaddons level.
additionally, the message now talks about failure to load rather
than error loading so as to make it a bit less important

Test Plan


Diff Detail

R244 KCoreAddons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jan 22 2020, 12:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 22 2020, 12:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Jan 22 2020, 12:36 PM
ngraham accepted this revision.Jan 22 2020, 2:35 PM
ngraham added a subscriber: ngraham.

Makes sense to me.

This revision is now accepted and ready to land.Jan 22 2020, 2:35 PM
mpyne accepted this revision.Jan 23 2020, 1:51 AM

Agreed, let's commit.

This revision was automatically updated to reflect the committed changes.