Differential D26791

prefer the new kcm plugins to the old
ClosedPublic
Actions

Authored by mart on Jan 20 2020, 12:52 PM.

Details

Reviewers
sitter
davidedmundson
Group Reviewers
Plasma
Commits
R295:9afc55415793: prefer the new kcm plugins to the old
Summary

swap the logic, if the same kcm has both the new and old plugins format
(for instance a stray build from source) now it prefers the new plugin format,
as it tries plugins/kcms beforehand

Test Plan

still loads both new and old kcms

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jan 20 2020, 12:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 20 2020, 12:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Jan 20 2020, 12:52 PM
davidedmundson accepted this revision.Jan 20 2020, 1:03 PM
davidedmundson added a subscriber: davidedmundson.

++++

src/kcmoduleloader.cpp
98

I dislike using the term "Error" for something that is perfectly legitimate.

This revision is now accepted and ready to land.Jan 20 2020, 1:03 PM
Closed by commit R295:9afc55415793: prefer the new kcm plugins to the old (authored by mart). · Explain WhyJan 20 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.
mart marked an inline comment as done.Jan 20 2020, 1:14 PM

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleloader.cpp (35 lines)

Diff 73936

View Options

src/kcmoduleloader.cpp

Loading...