Differential D26769

Always strip html if server does not support it
ClosedPublic
Actions

Authored by nicolasfella on Jan 19 2020, 4:26 PM.

Details

Reviewers
broulik
mart
Group Reviewers
Frameworks
Commits
R289:994f88929a83: Always strip html if server does not support it
Summary

The spec does not say that text containing markup has to be enclosed in <html> tags

Test Plan

Text with bold markup is shown bold on plasma. Plain text is shown when no markup is supported

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jan 19 2020, 4:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 19 2020, 4:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 19 2020, 4:26 PM
broulik accepted this revision.Feb 17 2020, 11:17 AM

Also, title must never be HTML, there's a reason the capability is called body-markup :)

This revision is now accepted and ready to land.Feb 17 2020, 11:17 AM
mart accepted this revision.Feb 17 2020, 11:19 AM
ngraham added a subscriber: ngraham.Feb 18 2020, 6:46 PM

+1 yes please

Closed by commit R289:994f88929a83: Always strip html if server does not support it (authored by nicolasfella). · Explain WhyFeb 19 2020, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/notifybypopup.cpp (8 lines)

Diff 76030

View Options

src/notifybypopup.cpp

Loading...