KCM/Component Revamp Browser config
ClosedPublic

Authored by meven on Jan 17 2020, 4:01 PM.

Details

Summary

Simplify UI:

  • Select option in the available browser
  • use mimeapps.list preferred service as source of truth regarding default browser
  • Can select any program as browser
  • falkon is used as default browser when installed

BUG: 100016
FIXED-IN: 5.19.0

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
browser-settings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21399
Build 21417: arc lint + arc unit
meven created this revision.Jan 17 2020, 4:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2020, 4:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 17 2020, 4:01 PM
meven edited the test plan for this revision. (Show Details)Jan 17 2020, 4:02 PM
meven added inline comments.Jan 17 2020, 4:08 PM
kcms/componentchooser/componentchooserbrowser.cpp
79 ↗(On Diff #73782)

Do we want to set falkon or konqueror as default ?

86

With the remove as this possible setting, we don't have a way to set things as they were.
But I don't this is an issue, the behavior encompassed here, is I believe already gone in KRun (where KRun would determine the http resource mimetype and launch the appropriate application accordingly).

The "Dans une application fondée sue le contenu d l'URL" setting is actually something I proposed removing in D17372, and it got approval in theory, but it seems like this is quite a far-reaching change that requires many considerations.

A lot of the discussion in D17372 kind of went over my head, so feel free to take over on that if you'd like.

ngraham accepted this revision.Jan 17 2020, 4:23 PM
ngraham added a reviewer: dfaure.

Works for me FWIW.

This revision is now accepted and ready to land.Jan 17 2020, 4:23 PM
ngraham edited the summary of this revision. (Show Details)Jan 17 2020, 4:24 PM
ervin added inline comments.Jan 20 2020, 1:51 PM
kcms/componentchooser/componentchooserbrowser.cpp
79 ↗(On Diff #73782)

If any it'd be falkon I think

meven updated this revision to Diff 73947.Jan 20 2020, 3:09 PM
meven marked an inline comment as done.

Use falkon as default browser when it is installed

ervin accepted this revision.Jan 20 2020, 3:21 PM
meven updated this revision to Diff 73952.Jan 20 2020, 3:33 PM

Inversion of variable to check

meven edited the summary of this revision. (Show Details)Jan 20 2020, 3:42 PM
This revision was automatically updated to reflect the committed changes.