Differential D26707

Fix QRegularExpression::wildcardToRegularExpression() usage
ClosedPublic
Actions

Authored by ahmadsamir on Jan 16 2020, 1:59 PM.

Details

Reviewers
apol
dfaure
Group Reviewers
Frameworks
Commits
R311:d4980443755f: Fix QRegularExpression::wildcardToRegularExpression() usage
Summary

It turns out that QRegularExpression::wildcardToRegularExpression() returns
an anchored (with \A and \z) pattern, so using anchoredPattern() in such
cases would actually anchor the pattern twice, which is obviously wrong.
Thanks to Mikołaj Płomieński (blaze) for catching it in
https://phabricator.kde.org/D26205#594891

Test Plan

make && ctest

Diff Detail

Repository
R311 KWallet
Branch
l-qregularexpression-wildcard (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21230
Build 21248: arc lint + arc unit
ahmadsamir created this revision.Jan 16 2020, 1:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 16 2020, 1:59 PM
ahmadsamir requested review of this revision.Jan 16 2020, 1:59 PM
apol accepted this revision.Jan 16 2020, 5:00 PM
This revision is now accepted and ready to land.Jan 16 2020, 5:00 PM
Closed by commit R311:d4980443755f: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). · Explain WhyJan 16 2020, 6:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73702

View Options

src/api/KWallet/kwallet.cpp

Loading...
View Options

src/runtime/kwalletd/backend/kwalletbackend.cc

Loading...