Differential D26697

Message-related methods: Use more member-function-pointer-based connect
ClosedPublic
Actions

Authored by kossebau on Jan 15 2020, 8:34 PM.

Details

Reviewers
dhaumann
cullmann
Commits
R39:6db5cb3ea2ba: Message-related methods: Use more member-function-pointer-based connect

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 15 2020, 8:34 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 15 2020, 8:34 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 15 2020, 8:34 PM
kossebau updated this revision to Diff 74711.Jan 30 2020, 5:03 PM

rebase to latest master
ping? :)

cullmann accepted this revision.Jan 30 2020, 6:43 PM
cullmann added a subscriber: cullmann.

Looks ok, too, thanks!

This revision is now accepted and ready to land.Jan 30 2020, 6:43 PM
Closed by commit R39:6db5cb3ea2ba: Message-related methods: Use more member-function-pointer-based connect (authored by kossebau). · Explain WhyJan 30 2020, 6:59 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a comment.Jan 30 2020, 9:05 PM

In two days we have the next KDE Frameworks tag. I'd have preferred a commit on Sunday ;)

Revision Contents
Changeset List

Diff 74724

View Options

src/document/katedocument.cpp

Loading...
View Options

src/view/katemessagewidget.cpp

Loading...