[kcms/feedback] Fix slider value

Authored by davidedmundson on Jan 15 2020, 10:43 AM.

Description

[kcms/feedback] Fix slider value

Summary:
If the kcm's property changes externally we don't update the slider
after the initial load, which is before KConfigModule::load which actually sets
the property.

Whilst there is an alternative fix calling load() a second time, we need
this anyway for default and reset buttons to work correctly.

I also think the original code was broken, I don't see why we would map
the value back to modeOptions[idx], we want the slider value to be the
index of the array, not the enum value. They just happen to be the same.

Test Plan: Opened KCM changed it, opened KCM repeat

Reviewers: Plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D26678

Details

Committed
davidedmundsonJan 15 2020, 10:43 AM
Reviewer
ngraham
Differential Revision
D26678: [kcms/feedback] Fix slider value
Parents
R120:4cb2eae9aa36: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown