Differential D26680

[kcms/feedback] Implement setRepresentsDefaults
ClosedPublic
Actions

Authored by davidedmundson on Jan 15 2020, 1:26 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:1f75ac80b6ac: [kcms/feedback] Implement setRepresentsDefaults
Test Plan

Moved slider
Defaults button enabled/disabled appropriately

Diff Detail

Repository
R120 Plasma Workspace
Branch
origin-master (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21166
Build 21184: arc lint + arc unit
davidedmundson created this revision.Jan 15 2020, 1:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 15 2020, 1:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 15 2020, 1:26 AM
ngraham accepted this revision.Jan 15 2020, 2:55 AM
This revision is now accepted and ready to land.Jan 15 2020, 2:55 AM
meven added a subscriber: meven.Jan 15 2020, 8:31 AM
meven added inline comments.
kcms/feedback/feedback.cpp
43

nitpick, You could move this to Feedback::setPlasmaFeedbackLevel as well.
1 saves a connect,
2 make setRepresesentsDefault and setNeedsSave close in the file

Closed by commit R120:1f75ac80b6ac: [kcms/feedback] Implement setRepresentsDefaults (authored by davidedmundson). · Explain WhyJan 15 2020, 10:44 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson added inline comments.Jan 15 2020, 11:42 AM
kcms/feedback/feedback.cpp
43

sorry I missed your comment.

I'll make this change.

Revision Contents
Changeset List

PathPackages
Mkcms/feedback/feedback.h (7 lines)
Mkcms/feedback/feedback.cpp (8 lines)

Diff 73589

View Options

kcms/feedback/feedback.h

Loading...
View Options

kcms/feedback/feedback.cpp

Loading...