Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R242:02e57319f791: Same behavior for scrollbar as the desktop style
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- phab/newscrollbar
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21131 Build 21149: arc lint + arc unit
actually, doesn't look that good.
this is because the scrollview has some margins and no frame, so now the scrollbar appears not centered.
those plasmoids would need to not have any margin with their content, or preferably, having the scrollviews enlarging to touch exactly the applet borders
best case scenario, we should have a look along the lines (gimped):
I would put for now an exception for plasmoids to not have such line, then in a second moment we think about a proper and more complicated solution to update plasmoids design to have something along the lines of the latter mockup
Yeah that's fine for now. We can adjust plasmoid layouts to better accommodate the line in Plasma 5.19.
| src/declarativeimports/plasmacomponents3/ScrollBar.qml | ||
|---|---|---|
| 102 ↗ | (On Diff #73525) | Math.round? |
| 106 ↗ | (On Diff #73525) | Math.round |
| src/desktoptheme/breeze/widgets/scrollbar.svg | ||
| 149 ↗ | (On Diff #73525) | We seem to have lost a lot of pixel alignment. Probably won't make any difference unless you render at 20000x the size, but might be worth asking Noah/someone how they do it. |