Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one
ClosedPublic
Actions

Authored by ahmadsamir on Jan 14 2020, 11:32 AM.

Details

Reviewers

Group Reviewers

Frameworks

Commits

Summary

This adds a perlSplit() overload that takes a QRegularExpression
parameter, and also deprecates the version that took a QRegExp param.

For both functions, return early if the string to be split is empty.

Test Plan

make && ctest

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir requested review of this revision.Jan 14 2020, 11:32 AM

There could be a ton more unittests, but OK, good enough since the old code didn't have more.

This revision is now accepted and ready to land.Jan 15 2020, 11:18 PM

This revision was automatically updated to reflect the committed changes.

FRT, there's only one usage of perlSplit(QChar...), https://lxr.kde.org/source/kde/kdemultimedia/libkcddb/libkcddb/cdinfo.cpp#0313
nothing else uses any of the perlSplit() functions.

			Path	Packages
M			autotests/kstringhandlertest.cpp (3 lines)
M			src/lib/CMakeLists.txt (2 lines)
M			src/lib/text/kstringhandler.h (29 lines)
M			src/lib/text/kstringhandler.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73509	9329bdc		Jan 14 2020, 11:32 AM	★	★
Diff 2	73817	6b7acfb	R244:aa908f7b2006e8329505b7a2247046f369d8c5ec	Jan 18 2020, 7:17 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d37c88b044ae	2353fda4dd72	9329bdc25bd4	Ahmad Samir	Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp… (Show More…)	Jan 14 2020, 11:27 AM