Deprecate raiseWidget
ClosedPublic

Authored by nicolasfella on Sat, Jan 11, 11:25 PM.

Details

Summary

It is unused. Furthermore, it relies on QtWidgets API which we try to get rid of in KNotifications. I assume the intention of this method was to raise the window when the notification is clicked, but this should be done by settng a default action and using appropriate QWindow API.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sat, Jan 11, 11:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Jan 11, 11:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sat, Jan 11, 11:25 PM
apol accepted this revision.Sun, Jan 12, 12:12 AM
This revision is now accepted and ready to land.Sun, Jan 12, 12:12 AM
This revision was automatically updated to reflect the committed changes.

Hi. When introducing the deprecation macros to a lib with ecm_generate_export_header, one also needs to help kapidox & ecm_add_qch. Sadly this was only discovered later, so it is also missing from the first set of such commits introducing the use of ecm_generate_export_headerwhich you might have taken as template :)

bdd8930cca99d81a5a5d4714b267419576e30ede fixes this. Teaching the documentation tools is meanwhile also documented at https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API so hopefully future additions of ecm_generate_export_header will have all things set as needed from the start. Yes, all these duplications are hell. In a perfect world all this depreaction support would be part of the language specification, and tools would handle things be default... for now this is the best someone came up with.

src/CMakeLists.txt
95

This also needs the definition as option in the toplevel file. Fixed by 191078e9387b3b591c46d68f884a18ad96b4f2f6