Consistency: colored selected buttons
ClosedPublic

Authored by mart on Thu, Jan 9, 11:59 AM.

Details

Summary

color selected buttons to the highlight color when it has keyboard
focus.
This makes the behavior much more similar to the Breeze desktop style

Test Plan

selected buttons look blue on Breeze, old themes still work as they did
Before


After

QWidget

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Thu, Jan 9, 11:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Jan 9, 11:59 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Thu, Jan 9, 11:59 AM
mart edited the test plan for this revision. (Show Details)Thu, Jan 9, 12:00 PM
ngraham accepted this revision.Thu, Jan 9, 3:50 PM
ngraham added a reviewer: Goal: Consistency.
ngraham added a subscriber: ngraham.

+1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't move keyboard focus there like it does for widgets and qqc2 desktop style.

This revision is now accepted and ready to land.Thu, Jan 9, 3:50 PM
mart added a comment.Thu, Jan 9, 4:31 PM

+1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't move keyboard focus there like it does for widgets and qqc2 desktop style.

that's a qqc1 issue i think

Can you update tests/components/button.qml tests/components/button3.qml

just a button with "focus: true" and some label that says "this should be highlighted on load"

This revision was automatically updated to reflect the committed changes.
mart added a comment.Thu, Jan 9, 4:36 PM

Can you update tests/components/button.qml tests/components/button3.qml

just a button with "focus: true" and some label that says "this should be highlighted on load"

done post landing