Consistency: colored selected buttons
ClosedPublic
Actions

Authored by mart on Jan 9 2020, 11:59 AM.

Details

Reviewers

Group Reviewers

Plasma
VDG
Goal: Consistency

Commits

R242:1d6870b15624: Consistency: colored selected buttons

Summary

color selected buttons to the highlight color when it has keyboard
focus.
This makes the behavior much more similar to the Breeze desktop style

Test Plan

selected buttons look blue on Breeze, old themes still work as they did
Before

After

QWidget

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart created this revision.Jan 9 2020, 11:59 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 9 2020, 11:59 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mart requested review of this revision.Jan 9 2020, 11:59 AM

Harbormaster completed remote builds in B20843: Diff 73122.Jan 9 2020, 11:59 AM

mart edited the test plan for this revision. (Show Details)Jan 9 2020, 12:00 PM

+1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't move keyboard focus there like it does for widgets and qqc2 desktop style.

This revision is now accepted and ready to land.Jan 9 2020, 3:50 PM

In D26540#590892, @ngraham wrote:

+1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't move keyboard focus there like it does for widgets and qqc2 desktop style.

that's a qqc1 issue i think

Can you update tests/components/button.qml tests/components/button3.qml

just a button with "focus: true" and some label that says "this should be highlighted on load"

Closed by commit R242:1d6870b15624: Consistency: colored selected buttons (authored by mart). · Explain WhyJan 9 2020, 4:32 PM

This revision was automatically updated to reflect the committed changes.

In D26540#590924, @davidedmundson wrote:

Can you update tests/components/button.qml tests/components/button3.qml

just a button with "focus: true" and some label that says "this should be highlighted on load"

done post landing

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmacomponents3/Button.qml (9 lines)
M			src/declarativeimports/plasmastyle/ButtonStyle.qml (10 lines)
M			src/desktoptheme/breeze/widgets/button.svg (580 lines)