Path: add ancestor method
AbandonedPublic

Authored by kossebau on Sep 4 2016, 12:40 PM.

Details

Reviewers
mwolff
nicolaih
Group Reviewers
KDevelop

Diff Detail

Repository
R33 KDevPlatform
Branch
pub-path1-ancestor
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolaih updated this revision to Diff 6421.Sep 4 2016, 12:40 PM
nicolaih retitled this revision from to Path: add ancestor method.
nicolaih updated this object.
nicolaih edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 4 2016, 12:40 PM
mwolff requested changes to this revision.Sep 5 2016, 2:26 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

good overall, but please add some unit test coverage (see test_path.{cpp,h}).

util/path.cpp
443

const

util/path.h
334

Qt style: use uint

This revision now requires changes to proceed.Sep 5 2016, 2:26 PM
kfunk added a comment.Jan 9 2017, 8:07 AM

Bump? Are you planning to work on that patch, Nicolai?

ping? otherwise I'll take over

Hi @mwolff , still plans to take over? Otherwise I would propose to mark it abandoned, so our list of patches to review is clean from (currently) dead things.

kossebau commandeered this revision.Oct 28 2018, 12:52 PM
kossebau abandoned this revision.
kossebau added a reviewer: nicolaih.

Abandoning for now given inactivity by the original author, for cleaning the to-review list. Still hoping one day someone/you will pick up this again.