MissingIncludeAssistant: use the compilation unit as a path
ClosedPublic

Authored by nicolaih on Sep 4 2016, 12:36 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Summary

For the purpose of determining where custom defines and includes should
be added, the final location of the diagnostic is irrelevant: it's the
path to the compilation unit itself that matters, since that's where the
corresponding configuration is taken from.

If you have a missing include file in an include file, compilationUnit()
gives the path in which a custom include should be added, unlike
finalLocation().

Diff Detail

Repository
R32 KDevelop
Branch
pub-includes1-compilation-unit
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolaih updated this revision to Diff 6419.Sep 4 2016, 12:36 PM
nicolaih retitled this revision from to MissingIncludeAssistant: use the compilation unit as a path.
nicolaih updated this object.
nicolaih edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 4 2016, 12:36 PM
mwolff accepted this revision.Sep 5 2016, 2:38 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm

This revision is now accepted and ready to land.Sep 5 2016, 2:38 PM

Hey there,

since this wasn't merged, I assume you don't have commit rights. I will gladly commit this for you, but I need to know your name and email address. I'll put that into the git author field then, to keep this patch attributed to you

Thanks

In D2649#87485, @mwolff wrote:

Hey there,

since this wasn't merged, I assume you don't have commit rights. I will gladly commit this for you, but I need to know your name and email address. I'll put that into the git author field then, to keep this patch attributed to you

Thanks

Name & email address could be taken from the data in identity.kde.org (which also matches the one used at https://github.com/nhaehnle, thus seems okay as public info).
Hi @nicolaih, it would still be good to have you confirm here that using these data is also okay for this patch. TIA

mwolff closed this revision.Nov 19 2017, 10:26 PM

this was merged already, closing