Differential D26413

Hide Kuit::setupForDomain and KuitSetup from the public API
AbandonedPublic
Actions

Authored by dfaure on Jan 4 2020, 9:46 AM.

Details

Reviewers
ilic
Summary

Since setupForDomain wasn't exported, there was no way to use
the KuitSetup API. So obviously nobody has used it, in many years,
which makes me wonder if it's really needed as part of the API.

Test Plan

make && ctest

Diff Detail

Repository
R249 KI18n
Branch
2020_01_hide_kuitsetup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20603
Build 20621: arc lint + arc unit
dfaure created this revision.Jan 4 2020, 9:46 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2020, 9:46 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jan 4 2020, 9:46 AM
dfaure mentioned this in D26408: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker.Jan 4 2020, 9:47 AM

Alternative approach: export it and unittest it, D26408.

@ilic your input would be very welcome on which approach should be taken. I don't care much personally, it's just really inconsistent right now (looks like public API, but is NOT public API)

ilic added a comment.Jan 4 2020, 10:46 AM
In D26413#587390, @dfaure wrote:

Alternative approach: export it and unittest it, D26408.

@ilic your input would be very welcome on which approach should be taken. I don't care much personally, it's just really inconsistent right now (looks like public API, but is NOT public API)

I did intended it as public API, its usage is even explained in the Programmers Guide. So for the moment I would go with D26408.

For KF6 I'd leave decision to others: should a piece of public API that seemed like it could have been useful but no-one ever tried to use in more than seven years, still remain public API?

dfaure added a comment.Jan 5 2020, 12:43 AM
In D26413#587425, @ilic wrote:

I did intended it as public API, its usage is even explained in the Programmers Guide. So for the moment I would go with D26408.

OK, feel free to approve that one then :-)

For KF6 I'd leave decision to others: should a piece of public API that seemed like it could have been useful but no-one ever tried to use in more than seven years, still remain public API?

I have my doubts, but I'm willing to try until KF7 ;)

dfaure abandoned this revision.Jan 5 2020, 7:23 PM

Revision Contents
Changeset List

PathPackages
Msrc/kuitmarkup.h (107 lines)
Msrc/kuitmarkup.cpp (54 lines)

Diff 72728

View Options

src/kuitmarkup.h

Loading...
View Options

src/kuitmarkup.cpp

Loading...