Differential D26408

ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker
ClosedPublic
Actions

Authored by dfaure on Jan 4 2020, 12:39 AM.

Details

Reviewers
ilic
Commits
R249:836908f3b83e: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker
Summary

This was initially to test the port to QRegularExpression in D26366,
it turned out that setupForDomain was meant to be exported, since
KUitSetup was exported.

Test Plan

test passes

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Jan 4 2020, 12:39 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2020, 12:39 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jan 4 2020, 12:39 AM
dfaure added a comment.Jan 4 2020, 9:47 AM

This makes KuitSetup actually usable from applications.

Alternative approach: D26413

ilic accepted this revision.Jan 5 2020, 4:59 PM
This revision is now accepted and ready to land.Jan 5 2020, 4:59 PM
dfaure updated this revision to Diff 72814.Jan 5 2020, 5:29 PM
dfaure retitled this revision from ki18n: add unittest for KUitSetup::setFormatForMarker to ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker.
dfaure edited the summary of this revision. (Show Details)

Update commit log

Closed by commit R249:836908f3b83e: ki18n: export Kuit::setupForDomain, unittest KUitSetup::setFormatForMarker (authored by dfaure). · Explain WhyJan 5 2020, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72815

View Options

autotests/klocalizedstringtest.h

Loading...
View Options

autotests/klocalizedstringtest.cpp

Loading...
View Options

src/kuitmarkup.h

Loading...