IconSize is deprecated.
Using the "Desktop" icon size was somewhat arbitrary. There is no QStyle pixelmetric that offers the same size and fits semantically.
davidedmundson |
Ark |
IconSize is deprecated.
Using the "Desktop" icon size was somewhat arbitrary. There is no QStyle pixelmetric that offers the same size and fits semantically.
Side panel, properties dialog and extraction dialog look the same
No Linters Available |
No Unit Test Coverage |
Buildable 20545 | |
Build 20563: arc lint + arc unit |
@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.
kerfuffle/extractiondialog.cpp | ||
---|---|---|
85 ↗ | (On Diff #72634) | We can use PM_LargeIconSize here. |
kerfuffle/propertiesdialog.cpp | ||
104 ↗ | (On Diff #72634) | We can use PM_LargeIconSize here. The icon in the properties dialog is pointless anyway. |
part/infopanel.cpp | ||
35 | Why remove static ? | |
36 ↗ | (On Diff #72628) | The infopanel is the only place where the Desktop size made sense (lots of space), at most we can hardcode 48 only here. |