Diffusion Ark 8e436fad4cd1

Optimize ArchiveModel::cleanFileName

Authored by nicolasfella on Jan 2 2020, 12:17 AM.

Description

Optimize ArchiveModel::cleanFileName

Summary: Creating the QRegularExpression is expensive and cleanFileName is called for each entry. By not re-creating the regex we gain a significant archive load time improvement

Test Plan:

Left is before, right is after. Note the red block on the left that isn't present on the right

Reviewers: Ark, elvisangelaccio

Reviewed By: Ark, elvisangelaccio

Subscribers: elvisangelaccio, kde-utils-devel

Tags: Ark

Differential Revision: https://phabricator.kde.org/D25565

Details

Committed
nicolasfellaJan 2 2020, 3:05 PM
Reviewer
Ark
Differential Revision
D25565: Optimize ArchiveModel::cleanFileName
Parents
R36:15c9cc6b56c6: Revert "Optimize ArchiveModel::cleanFileName"
Branches
Unknown
Tags
Unknown